filechoosererrorstack: Fix object life-cycle
authorMatthias Clasen <mclasen@redhat.com>
Wed, 25 Mar 2020 20:01:06 +0000 (16:01 -0400)
committerMatthias Clasen <mclasen@redhat.com>
Wed, 25 Mar 2020 21:04:29 +0000 (17:04 -0400)
Unparent children in dispose, not in finalize.

gtk/gtkfilechoosererrorstack.c

index 39e18c00020fea2d48f12ca3a94a6bc213b88eaf..9020946626c348caf09a1c4d863c22cc0dde60bb 100644 (file)
 G_DEFINE_TYPE (GtkFileChooserErrorStack, gtk_file_chooser_error_stack, GTK_TYPE_WIDGET)
 
 static void
-gtk_file_chooser_error_stack_finalize (GObject *object)
+gtk_file_chooser_error_stack_dispose (GObject *object)
 {
   GtkFileChooserErrorStack *self = GTK_FILE_CHOOSER_ERROR_STACK (object);
 
   g_clear_pointer (&self->stack, gtk_widget_unparent);
 
-  G_OBJECT_CLASS (gtk_file_chooser_error_stack_parent_class)->finalize (object);
+  G_OBJECT_CLASS (gtk_file_chooser_error_stack_parent_class)->dispose (object);
 }
 
 static void
@@ -36,7 +36,7 @@ gtk_file_chooser_error_stack_class_init (GtkFileChooserErrorStackClass *class)
   GObjectClass *object_class = G_OBJECT_CLASS (class);
   GtkWidgetClass *widget_class = GTK_WIDGET_CLASS (class);
 
-  object_class->finalize = gtk_file_chooser_error_stack_finalize;
+  object_class->dispose = gtk_file_chooser_error_stack_dispose;
 
   gtk_widget_class_set_layout_manager_type (widget_class, GTK_TYPE_BIN_LAYOUT);
 }